Skip to content

cam6_4_119: Bring in new atmospheric_physics tag and use CCPPized shortwave interfaces #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Sep 26, 2025
Merged

cam6_4_119: Bring in new atmospheric_physics tag and use CCPPized shortwave interfaces #1372

merged 33 commits into from
Sep 26, 2025

Conversation

peverwhee
Copy link
Collaborator

This PR:

  1. Brings in the new atmospheric physics submodule (currently a hash on my branch until RRTMGP SW module integration with CAM atmospheric_physics#262 is merged)
  2. Updates rrtmgp/radiation.F90 to use the new CCPPized interfaces.
  3. Removes the RRTMGP code external (as the external code now lives in atmospheric_physics) and updates the paths in configure to match the new location
  4. Remove code that has been moved to atmospheric_physics from rrtmgp_inputs_cam.F90

addresses #1192

@peverwhee peverwhee requested a review from nusbaume August 22, 2025 21:41
@peverwhee peverwhee self-assigned this Aug 22, 2025
nusbaume
nusbaume requested changes Sep 17, 2025
View reviewed changes
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing these changes into CAM @peverwhee! I just had a few small requests.

@peverwhee peverwhee requested a review from nusbaume September 22, 2025 21:03
nusbaume
nusbaume approved these changes Sep 23, 2025
View reviewed changes
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great to me now. Thanks again @peverwhee!

@cacraigucar cacraigucar changed the title Bring in new atmospheric_physics tag and use CCPPized shortwave interfaces cam6_4_118: Bring in new atmospheric_physics tag and use CCPPized shortwave interfaces Sep 23, 2025
@cacraigucar cacraigucar changed the title cam6_4_118: Bring in new atmospheric_physics tag and use CCPPized shortwave interfaces cam6_4_119: Bring in new atmospheric_physics tag and use CCPPized shortwave interfaces Sep 23, 2025
@peverwhee peverwhee merged commit 7bbbd1a into ESCOMP:cam_development Sep 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nusbaume nusbaume nusbaume approved these changes

Assignees

@peverwhee peverwhee

Labels
ccpp-conversion
Projects
CAM Development
Status: Tag
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peverwhee @nusbaume @cacraigucar